LuciferYang commented on code in PR #38162:
URL: https://github.com/apache/spark/pull/38162#discussion_r990920851
##########
project/SparkBuild.scala:
##########
@@ -655,19 +655,47 @@ object SparkConnect {
(assembly / logLevel) := Level.Info,
+ // Exclude `scala-library` from assembly.
+ (assembly / assemblyPackageScala / assembleArtifact) := false,
+
+ // Exclude `pmml-model-*.jar`,
`scala-collection-compat_*.jar`,`jsr305-*.jar` and
+ // `unused-1.0.0.jar` from assembly.
+ (assembly / assemblyExcludedJars) := {
+ val cp = (assembly / fullClasspath).value
+ cp filter { v =>
+ val name = v.data.getName
+ name.startsWith("pmml-model-") ||
name.startsWith("scala-collection-compat_") ||
Review Comment:
<img width="870" alt="image"
src="https://user-images.githubusercontent.com/1475305/194803168-f5f322ac-1226-4825-8642-721a4e1abd00.png";>
@HyukjinKwon The results are the same, from the document, it should be this
option, but it only excludes the `scala-library`, not the 'scala-collection
compat_'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/1475305/194803168-f5f322ac-1226-4825-8642-721a4e1abd00.png"](https://user-images.githubusercontent.com/1475305/194803168-f5f322ac-1226-4825-8642-721a4e1abd00.png"){kind=link}