HyukjinKwon commented on code in PR #38168:
URL: https://github.com/apache/spark/pull/38168#discussion_r991170773
##########
python/pyspark/sql/dataframe.py:
##########
@@ -2044,7 +2044,7 @@ def crossJoin(self, other: "DataFrame") -> "DataFrame":
def join(
self,
other: "DataFrame",
- on: Optional[Union[str, List[str], Column, List[Column]]] = None,
+ on: Optional[Union[str, List[str], bool, List[bool], Column,
List[Column]]] = None,
Review Comment:
That's actually an error from IDE (which assumes that the built-in functions
always return `bool`). The expected types here are correct in fact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
