[GitHub] [spark] Hongbo-Miao commented on a diff in pull request #38168: fix(type): add bool and List[bool] for join's on input

Mon, 10 Oct 2022 23:04:34 -0700 


Hongbo-Miao commented on code in PR #38168:
URL: https://github.com/apache/spark/pull/38168#discussion_r991823511


##########
python/pyspark/sql/dataframe.py:
##########
@@ -2044,7 +2044,7 @@ def crossJoin(self, other: "DataFrame") -> "DataFrame":
     def join(
         self,
         other: "DataFrame",
-        on: Optional[Union[str, List[str], Column, List[Column]]] = None,
+        on: Optional[Union[str, List[str], bool, List[bool], Column, 
List[Column]]] = None,

Review Comment:
   I see. I found something interesting.
   
   Intellij IDEA has no issue with pandas `join`'s `on`.
   <img width="1461" alt="image" 
src="https://user-images.githubusercontent.com/3375461/195002907-e951789e-f723-4962-a02b-0abb55698146.png";>
   But seems only has issue for pyspark.
   
   Here is the way how pandas implement:
   
   - 
https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L9837-L9840
   - https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L121
   
   However, if it is still an IDE issue, the IDE definitely fix it for sure. 😃



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to