brkyvz commented on code in PR #38113:
URL: https://github.com/apache/spark/pull/38113#discussion_r991729733
##########
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala:
##########
@@ -2272,6 +2272,18 @@ abstract class AvroSuite
checkAnswer(df2, df.collect().toSeq)
}
}
+
+ test("SPARK-40667: validate Avro Options") {
+ assert(AvroOptions.isValidOption("ignoreExtension"))
Review Comment:
The developer nor the reviewer may not know such a test exists. The failing
of the test will let them know. The reviewer can ensure that the same pattern
is followed for all other options, but they may not know whether a test needs
to be added or updated. This will ensure that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
