amaliujia commented on code in PR #38166:
URL: https://github.com/apache/spark/pull/38166#discussion_r991764630
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -107,15 +107,17 @@ message Join {
}
}
-// Relation of type [[Union]], at least one input must be set.
Review Comment:
I am thinking it should be always two inputs so the implementation should be
correct. Though I don't know enough about dataframe API usage so not sure if
there could be only one, or more than two, etc.
Given proto is also a API layer, before 3.4 release I think we need to add a
lot more comments on proto to clarify each one's semantic. We can finalize how
many inputs are possible at that time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
