cloud-fan commented on code in PR #38166:
URL: https://github.com/apache/spark/pull/38166#discussion_r991769641
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -108,15 +108,17 @@ message Join {
}
}
-// Relation of type [[Union]], at least one input must be set.
-message Union {
+// Relation of type [[SetOperation]]
+message SetOperation {
repeated Relation inputs = 1;
- UnionType union_type = 2;
-
- enum UnionType {
- UNION_TYPE_UNSPECIFIED = 0;
- UNION_TYPE_DISTINCT = 1;
- UNION_TYPE_ALL = 2;
+ SetOpType set_op_type = 2;
+ bool is_all = 3;
+
+ enum SetOpType {
+ SET_OP_TYPE_UNSPECIFIED = 0;
+ SET_OP_TYPE_INTERSECT = 1;
+ SET_OP_TYPE_ALL = 2;
Review Comment:
```suggestion
SET_OP_TYPE_UNION = 2;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
