martin-g commented on code in PR #5:
URL: https://github.com/apache/spark-docker/pull/5#discussion_r992092701


##########
.github/workflows/build_3.3.0.yaml:
##########
@@ -20,15 +20,18 @@
 name: "Build and Test (3.3.0)"
 
 on:
-  pull_request:
+  pull_request_target:
     branches:
       - 'master'
     paths:
-      - '3.3.0/'
+      - '3.3.0/**'
+      - '.github/workflows/build_3.3.0.yaml'
       - '.github/workflows/main.yml'
 
 jobs:
   run-build:
+    permissions:
+      packages: write

Review Comment:
   Is this needed ? This workflow just delegates to `main.yml` where this is 
also specified.
   It does not do any harm either!



##########
.github/workflows/main.yml:
##########
@@ -70,7 +72,9 @@ jobs:
       - name: Generate tags
         run: |
           TAG=scala${{ matrix.scala_version }}-java${{ matrix.java_version 
}}-${{ matrix.image_suffix }}
-
+          # The pull_request_target job:

Review Comment:
   ```suggestion
             # The pull_request_target event leads to:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to