Yikun commented on code in PR #5:
URL: https://github.com/apache/spark-docker/pull/5#discussion_r992400470
##########
.github/workflows/main.yml:
##########
@@ -98,7 +102,7 @@ jobs:
with:
context: ${{ env.IMAGE_PATH }}
push: true
- tags: ${{ env.TEST_REPO }}:${{ env.UNIQUE_IMAGE_TAG }}
+ tags: ${{ env.TEST_REPO }}/${{ env.IMAGE_NAME }}:${{
env.UNIQUE_IMAGE_TAG }}
Review Comment:
Emm, this might has some issue when multiple concurrency jobs push the same
tag. Of course, we could use [action
concurrency](https://docs.github.com/en/actions/using-jobs/using-concurrency)
or add some random hash tag to protect.
But after some consideration, I guess what we need to do just remove push in
this PR
```yaml
push: true
```
And change it to local build in minikube docker (don't do a real push) when
we adding K8s test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
