grundprinzip commented on code in PR #38192:
URL: https://github.com/apache/spark/pull/38192#discussion_r995378123
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -34,59 +36,109 @@ package object dsl {
val identifier = CatalystSqlParser.parseMultipartIdentifier(s)
def protoAttr: proto.Expression =
- proto.Expression.newBuilder()
+ proto.Expression
+ .newBuilder()
.setUnresolvedAttribute(
- proto.Expression.UnresolvedAttribute.newBuilder()
+ proto.Expression.UnresolvedAttribute
+ .newBuilder()
.addAllParts(identifier.asJava)
.build())
.build()
}
implicit class DslExpression(val expr: proto.Expression) {
- def as(alias: String): proto.Expression =
proto.Expression.newBuilder().setAlias(
-
proto.Expression.Alias.newBuilder().setName(alias).setExpr(expr)).build()
-
- def < (other: proto.Expression): proto.Expression =
- proto.Expression.newBuilder().setUnresolvedFunction(
- proto.Expression.UnresolvedFunction.newBuilder()
- .addParts("<")
- .addArguments(expr)
- .addArguments(other)
- ).build()
+ def as(alias: String): proto.Expression = proto.Expression
Review Comment:
It's an annoying mix. The conflict resolution on the merge conflict was ugly
and then I had to clean it up. Doing this manually sucks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
