grundprinzip commented on code in PR #38192:
URL: https://github.com/apache/spark/pull/38192#discussion_r995421139
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -34,59 +36,109 @@ package object dsl {
val identifier = CatalystSqlParser.parseMultipartIdentifier(s)
def protoAttr: proto.Expression =
- proto.Expression.newBuilder()
+ proto.Expression
+ .newBuilder()
.setUnresolvedAttribute(
- proto.Expression.UnresolvedAttribute.newBuilder()
+ proto.Expression.UnresolvedAttribute
+ .newBuilder()
.addAllParts(identifier.asJava)
.build())
.build()
}
implicit class DslExpression(val expr: proto.Expression) {
- def as(alias: String): proto.Expression =
proto.Expression.newBuilder().setAlias(
-
proto.Expression.Alias.newBuilder().setName(alias).setExpr(expr)).build()
-
- def < (other: proto.Expression): proto.Expression =
- proto.Expression.newBuilder().setUnresolvedFunction(
- proto.Expression.UnresolvedFunction.newBuilder()
- .addParts("<")
- .addArguments(expr)
- .addArguments(other)
- ).build()
+ def as(alias: String): proto.Expression = proto.Expression
+ .newBuilder()
+
.setAlias(proto.Expression.Alias.newBuilder().setName(alias).setExpr(expr))
+ .build()
+
+ def <(other: proto.Expression): proto.Expression =
+ proto.Expression
+ .newBuilder()
+ .setUnresolvedFunction(
+ proto.Expression.UnresolvedFunction
+ .newBuilder()
+ .addParts("<")
+ .addArguments(expr)
+ .addArguments(other))
+ .build()
}
implicit def intToLiteral(i: Int): proto.Expression =
- proto.Expression.newBuilder().setLiteral(
- proto.Expression.Literal.newBuilder().setI32(i)
- ).build()
+ proto.Expression
+ .newBuilder()
+ .setLiteral(proto.Expression.Literal.newBuilder().setI32(i))
+ .build()
+ }
+
+ object commands { // scalastyle:ignore
+ implicit class DslCommands(val logicalPlan: proto.Relation) {
+ def write(
+ format: Option[String] = None,
+ path: Option[String] = None,
+ tableName: Option[String] = None,
+ mode: Option[String] = None,
+ sortByColumns: Seq[String] = Seq.empty,
+ partitionByCols: Seq[String] = Seq.empty,
+ bucketByCols: Seq[String] = Seq.empty,
+ numBuckets: Option[Int] = None): proto.Command = {
+ val writeOp = proto.WriteOperation.newBuilder()
+ format.foreach(writeOp.setSource(_))
+
+ mode
+ .map(SaveMode.valueOf(_))
+ .map(DataTypeProtoConverter.toSaveModeProto(_))
+ .foreach(writeOp.setMode(_))
+
+ if (tableName.nonEmpty) {
+ tableName.foreach(writeOp.setTableName(_))
+ } else {
+ path.foreach(writeOp.setPath(_))
+ }
+ sortByColumns.foreach(writeOp.addSortColumnNames(_))
+ partitionByCols.foreach(writeOp.addPartitioningColumns(_))
+
+ if (numBuckets.nonEmpty && bucketByCols.nonEmpty) {
+ val op = proto.WriteOperation.BucketBy.newBuilder()
+ numBuckets.foreach(op.setNumBuckets(_))
+ bucketByCols.foreach(op.addBucketColumnNames(_))
+ writeOp.setBucketBy(op.build())
+ }
+ writeOp.setInput(logicalPlan)
+ proto.Command.newBuilder().setWriteOperation(writeOp.build()).build()
+ }
+ }
}
object plans { // scalastyle:ignore
implicit class DslLogicalPlan(val logicalPlan: proto.Relation) {
def select(exprs: proto.Expression*): proto.Relation = {
- proto.Relation.newBuilder().setProject(
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
