warrenzhu25 commented on code in PR #38231:
URL: https://github.com/apache/spark/pull/38231#discussion_r996207733
##########
core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala:
##########
@@ -65,7 +65,7 @@ private[spark] case class
HeartbeatResponse(reregisterBlockManager: Boolean)
* Lives in the driver to receive heartbeats from executors..
*/
private[spark] class HeartbeatReceiver(sc: SparkContext, clock: Clock)
- extends SparkListener with ThreadSafeRpcEndpoint with Logging {
+ extends SparkListener with ThreadSafeRpcEndpoint with IsolatedRpcEndpoint
with Logging {
Review Comment:
> Could you elaborate your scale of testing? Are you using this in the
production?
App with about 500+ executors. Yes, it's for production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]