dongjoon-hyun commented on code in PR #38231:
URL: https://github.com/apache/spark/pull/38231#discussion_r996612621
##########
core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala:
##########
@@ -65,7 +65,7 @@ private[spark] case class
HeartbeatResponse(reregisterBlockManager: Boolean)
* Lives in the driver to receive heartbeats from executors..
*/
private[spark] class HeartbeatReceiver(sc: SparkContext, clock: Clock)
- extends SparkListener with ThreadSafeRpcEndpoint with Logging {
+ extends SparkListener with ThreadSafeRpcEndpoint with IsolatedRpcEndpoint
with Logging {
Review Comment:
I understand what you mean, but it's still not-safe completely, isn't it? If
you are considering two different logic branches based on
`ThreadSafeRpcEndpoint` or `IsolatedRpcEndpoint`, this PR could break some of
the existing logic if the branching logic starts to match `IsolatedRpcEndpoint`
first.
> I'm not sure whether there're some logic depending on trait
ThreadSafeRpcEndpoint. To keep it safe, I just added new trait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
