grundprinzip commented on code in PR #38270:
URL: https://github.com/apache/spark/pull/38270#discussion_r996476445
##########
python/pyspark/sql/connect/column.py:
##########
@@ -73,20 +114,6 @@ def __str__(self) -> str:
return f"Literal({self._value})"
-def _bin_op(
- name: str, doc: str = "binary function", reverse: bool = False
-) -> Callable[["ColumnRef", Any], Expression]:
- def _(self: "ColumnRef", other: Any) -> Expression:
- if isinstance(other, get_args(PrimitiveType)):
- other = LiteralExpression(other)
- if not reverse:
- return ScalarFunctionExpression(name, self, other)
- else:
- return ScalarFunctionExpression(name, other, self)
-
- return _
-
-
class ColumnRef(Expression):
Review Comment:
Let's have a discussion about this, but this is an unrelated change to this
one. I think we should probably call `Expression` -> `Column` and `ColumnRef`
-> `AttributeReference` but it will require some more digging what the right
name should be. However, as said, that's independent of this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
