grundprinzip commented on code in PR #38270:
URL: https://github.com/apache/spark/pull/38270#discussion_r997387895
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -64,6 +64,36 @@ package object dsl {
.build()
}
+ /**
+ * Create an unresolved function from name parts.
+ *
+ * @param nameParts
+ * @param args
+ * @return Expression wrapping the unresolved function.
+ */
+ def fun(nameParts: Seq[String], args: Seq[proto.Expression]):
proto.Expression = {
Review Comment:
Oh nice, I definitely missed renaming the other overall `callFunction` as
well. TBH I'm not sure what the right approach is here because the catalyst DSL
calls it `callFunction` instead of `call_function` 🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
