rangadi commented on code in PR #38344:
URL: https://github.com/apache/spark/pull/38344#discussion_r1002893438
##########
connector/protobuf/pom.xml:
##########
@@ -123,6 +123,7 @@
<configuration>
<protocArtifact>com.google.protobuf:protoc:${protobuf.version}</protocArtifact>
<protocVersion>${protobuf.version}</protocVersion>
+ <includeMavenTypes>direct</includeMavenTypes>
Review Comment:
Could you add comment here?
Is this for protos like `Timestamp' ? Looks like our code handles any
Timestamp defined similar com.google.protobuf.Timestamp. Ok to not to include
these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
