SandishKumarHN commented on code in PR #38344: URL: https://github.com/apache/spark/pull/38344#discussion_r1003653232
########## connector/protobuf/pom.xml: ########## @@ -123,6 +123,7 @@ <configuration> <protocArtifact>com.google.protobuf:protoc:${protobuf.version}</protocArtifact> <protocVersion>${protobuf.version}</protocVersion> + <includeMavenTypes>direct</includeMavenTypes> Review Comment: @rangadi how about splitting Timestamp and Duration into our own .proto files and then importing them in the functions_suite.proto file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org