awdavidson commented on code in PR #38312:
URL: https://github.com/apache/spark/pull/38312#discussion_r1002902562
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala:
##########
@@ -271,6 +271,10 @@ class ParquetToSparkSchemaConverter(
} else {
TimestampNTZType
}
+ // SPARK-40819: NANOS are not supported as a Timestamp, convert to
LongType without
+ // timezone awareness to address behaviour regression introduced by
SPARK-34661
Review Comment:
I do not think this is a good idea as the precision will be lost which is
extremely important for high frequency time series.
I haven’t verified but end users/developers would still be able to
`.cast(Timestamp)` which I believe would truncate the timestamp; allowing
developers to make that decision makes more sense then forcing the loss of
precision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
