amaliujia commented on code in PR #38415:
URL: https://github.com/apache/spark/pull/38415#discussion_r1007556667
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -47,6 +47,13 @@ message Relation {
Unknown unknown = 999;
}
+ // Optional. Every relation might have an alias.
+ Alias alias = 200;
+
+ // Relation alias.
+ message Alias {
Review Comment:
default is empty string...
I really don't like the way of proto for this..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
