amaliujia commented on code in PR #38415:
URL: https://github.com/apache/spark/pull/38415#discussion_r1008797052
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -47,6 +47,13 @@ message Relation {
Unknown unknown = 999;
}
+ // Optional. Every relation might have an alias.
Review Comment:
Given that this is already a message, also if we want to match DataFrame
API, I think it makes more sense to have a `SubqueryAlias` in proto, and the
call for `as(alias)` in the client will just create this `SubqueryAlias`, which
is the same as existing DF implementation.
I have updated this PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
