LuciferYang commented on code in PR #38427:
URL: https://github.com/apache/spark/pull/38427#discussion_r1008677981
##########
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala:
##########
@@ -276,7 +276,7 @@ final class ShuffleBlockFetcherIterator(
val (size, mapIndex) = infoMap(blockId)
FetchBlockInfo(BlockId(blockId), size, mapIndex)
}
- results.put(DeferFetchRequestResult(FetchRequest(address,
blocks.toSeq)))
+ results.put(DeferFetchRequestResult(FetchRequest(address,
blocks.toIndexedSeq)))
Review Comment:
Maybe defining a helper method and providing different implementations for
Scala 2.12 and 2.13 can give consideration to both, but this may be too
complicated(like `org.apache.spark.util.Iterators`, It has implementations
corresponding to different Scala versions).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
