LuciferYang commented on code in PR #38427: URL: https://github.com/apache/spark/pull/38427#discussion_r1008821518
########## core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala: ########## @@ -457,7 +457,7 @@ final class ShuffleBlockFetcherIterator( } private def createFetchRequests( - curBlocks: Seq[FetchBlockInfo], + curBlocks: IndexedSeq[FetchBlockInfo], Review Comment: Since `createFetchRequests` is a private method, can we directly change the type of `curBlocks` to `Buffer or ArrayBuffer`? This allows Scala 2.12 and 2.13 to both achieve optimal performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
