LuciferYang commented on code in PR #38436:
URL: https://github.com/apache/spark/pull/38436#discussion_r1008825685
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -196,7 +198,8 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog {
hof.dataTypeMismatch(hof, checkRes)
case TypeCheckResult.TypeCheckFailure(message) =>
Review Comment:
Will it still match `TypeCheckResult.TypeCheckFailure(message)`?
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4339,5 +4339,170 @@
"message" : [
"Drop namespace restrict is not supported"
]
+ },
+ "_LEGACY_ERROR_TEMP_2300" : {
+ "message" : [
+ "The number of lambda function arguments '<namesSize>' does not match
the number of arguments expected by the higher order function '<argInfoSize>'."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2301" : {
+ "message" : [
+ "Lambda function arguments should not have names that are semantically
the same."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2302" : {
+ "message" : [
+ "'<name>' does not support more than one sources"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2303" : {
+ "message" : [
+ "incompatible types found in column <name> for inline table"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2304" : {
+ "message" : [
+ "cannot evaluate expression <sqlExpr> in inline table definition"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2305" : {
+ "message" : [
+ "expected <numCols> columns but found <rowSize> columns in row <ri>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2306" : {
+ "message" : [
+ "A lambda function should only be used in a higher order function.
However, its class is <class>, which is not a higher order function."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2307" : {
+ "message" : [
+ "Number of given aliases does not match number of output columns.
Function name: <funcName>; number of aliases: <aliasesNum>; number of output
columns: <outColsNum>."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2308" : {
+ "message" : [
+ "could not resolve `<name>` to a table-valued function"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2309" : {
+ "message" : [
+ "cannot resolve <sqlExpr> in MERGE command given columns [<cols>]"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2310" : {
+ "message" : [
+ "'writeStream' can be called only on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2311" : {
+ "message" : [
+ "'writeTo' can not be called on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2312" : {
+ "message" : [
+ "'write' can not be called on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2313" : {
+ "message" : [
+ "Hint not found: <name>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2314" : {
+ "message" : [
+ "cannot resolve '<sqlExpr>' due to argument data type mismatch: <msg>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2315" : {
+ "message" : [
+ "cannot resolve '<sqlExpr>' due to data type mismatch: <msg><hint>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2316" : {
+ "message" : [
+ "observed metrics should be named: <operator>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2317" : {
+ "message" : [
+ "window expressions are not allowed in observed metrics, but found:
<sqlExpr>"
Review Comment:
The following templates are similar. Will they be merged together in the
future?
- _LEGACY_ERROR_TEMP_2317
- _LEGACY_ERROR_TEMP_2319
- _LEGACY_ERROR_TEMP_2320
- _LEGACY_ERROR_TEMP_2321
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4339,5 +4339,170 @@
"message" : [
"Drop namespace restrict is not supported"
]
+ },
+ "_LEGACY_ERROR_TEMP_2300" : {
+ "message" : [
+ "The number of lambda function arguments '<namesSize>' does not match
the number of arguments expected by the higher order function '<argInfoSize>'."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2301" : {
+ "message" : [
+ "Lambda function arguments should not have names that are semantically
the same."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2302" : {
+ "message" : [
+ "'<name>' does not support more than one sources"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2303" : {
+ "message" : [
+ "incompatible types found in column <name> for inline table"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2304" : {
+ "message" : [
+ "cannot evaluate expression <sqlExpr> in inline table definition"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2305" : {
+ "message" : [
+ "expected <numCols> columns but found <rowSize> columns in row <ri>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2306" : {
+ "message" : [
+ "A lambda function should only be used in a higher order function.
However, its class is <class>, which is not a higher order function."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2307" : {
+ "message" : [
+ "Number of given aliases does not match number of output columns.
Function name: <funcName>; number of aliases: <aliasesNum>; number of output
columns: <outColsNum>."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2308" : {
+ "message" : [
+ "could not resolve `<name>` to a table-valued function"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2309" : {
+ "message" : [
+ "cannot resolve <sqlExpr> in MERGE command given columns [<cols>]"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2310" : {
Review Comment:
Will _LEGACY_ERROR_TEMP_2310, _LEGACY_ERROR_TEMP_2311,
_LEGACY_ERROR_TEMP_2312 be merged to one?
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4339,5 +4339,170 @@
"message" : [
"Drop namespace restrict is not supported"
]
+ },
+ "_LEGACY_ERROR_TEMP_2300" : {
+ "message" : [
+ "The number of lambda function arguments '<namesSize>' does not match
the number of arguments expected by the higher order function '<argInfoSize>'."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2301" : {
+ "message" : [
+ "Lambda function arguments should not have names that are semantically
the same."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2302" : {
+ "message" : [
+ "'<name>' does not support more than one sources"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2303" : {
+ "message" : [
+ "incompatible types found in column <name> for inline table"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2304" : {
+ "message" : [
+ "cannot evaluate expression <sqlExpr> in inline table definition"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2305" : {
+ "message" : [
+ "expected <numCols> columns but found <rowSize> columns in row <ri>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2306" : {
+ "message" : [
+ "A lambda function should only be used in a higher order function.
However, its class is <class>, which is not a higher order function."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2307" : {
+ "message" : [
+ "Number of given aliases does not match number of output columns.
Function name: <funcName>; number of aliases: <aliasesNum>; number of output
columns: <outColsNum>."
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2308" : {
+ "message" : [
+ "could not resolve `<name>` to a table-valued function"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2309" : {
+ "message" : [
+ "cannot resolve <sqlExpr> in MERGE command given columns [<cols>]"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2310" : {
+ "message" : [
+ "'writeStream' can be called only on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2311" : {
+ "message" : [
+ "'writeTo' can not be called on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2312" : {
+ "message" : [
+ "'write' can not be called on streaming Dataset/DataFrame"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2313" : {
+ "message" : [
+ "Hint not found: <name>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2314" : {
+ "message" : [
+ "cannot resolve '<sqlExpr>' due to argument data type mismatch: <msg>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2315" : {
+ "message" : [
+ "cannot resolve '<sqlExpr>' due to data type mismatch: <msg><hint>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2316" : {
+ "message" : [
+ "observed metrics should be named: <operator>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2317" : {
+ "message" : [
+ "window expressions are not allowed in observed metrics, but found:
<sqlExpr>"
+ ]
+ },
+ "_LEGACY_ERROR_TEMP_2318" : {
Review Comment:
`_LEGACY_ERROR_TEMP_2318` and `_LEGACY_ERROR_TEMP_2322` are similar, will
they merge together in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
