MaxGekk commented on code in PR #38436:
URL: https://github.com/apache/spark/pull/38436#discussion_r1008914087
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -196,7 +198,8 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog {
hof.dataTypeMismatch(hof, checkRes)
case TypeCheckResult.TypeCheckFailure(message) =>
Review Comment:
When we finish all tasks of converting the type check failures to error
classes, we will remove `TypeCheckResult.TypeCheckFailure()`, and as a
consequence of that, we can remove all match cases, and unneeded error classes
like this.
So far, there are open tasks, I wouldn't do that:
- https://issues.apache.org/jira/browse/SPARK-40371
- https://issues.apache.org/jira/browse/SPARK-40372
- https://issues.apache.org/jira/browse/SPARK-40374
- https://issues.apache.org/jira/browse/SPARK-40748
- https://issues.apache.org/jira/browse/SPARK-40749
- https://issues.apache.org/jira/browse/SPARK-40769
since there is a risk to miss something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
