cloud-fan commented on code in PR #38404:
URL: https://github.com/apache/spark/pull/38404#discussion_r1009015127
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -279,14 +282,26 @@ class AstBuilder extends SqlBaseParserBaseVisitor[AnyRef]
with SQLConfHelper wit
overwrite = false,
ifPartitionNotExists)
case table: InsertOverwriteTableContext =>
- val (relation, cols, partition, ifPartitionNotExists) =
visitInsertOverwriteTable(table)
+ val (relation, cols, partition, ifPartitionNotExists, _)
+ = visitInsertOverwriteTable(table)
InsertIntoStatement(
relation,
partition,
cols,
query,
overwrite = true,
ifPartitionNotExists)
+ case table: InsertIntoReplaceWhereContext =>
+ val (relation, cols, partition, ifPartitionNotExists,
replacePredicates)
+ = visitInsertIntoReplaceWhere(table)
+ InsertIntoStatement(
Review Comment:
can't we return `OverwriteByExpression` directly here? Then we don't need to
touch `InsertIntoStatement`. This is v2 code path only, and we don't need to
use `InsertIntoStatement` and covert it to either v1 or v2 code path later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
