cloud-fan commented on code in PR #38404: URL: https://github.com/apache/spark/pull/38404#discussion_r1021061558
########## sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ########## @@ -319,6 +319,7 @@ query insertInto : INSERT OVERWRITE TABLE? multipartIdentifier (partitionSpec (IF NOT EXISTS)?)? identifierList? #insertOverwriteTable | INSERT INTO TABLE? multipartIdentifier partitionSpec? (IF NOT EXISTS)? identifierList? #insertIntoTable + | INSERT INTO TABLE? multipartIdentifier REPLACE whereClause? identifierList? #insertIntoReplaceWhere Review Comment: `SELECT * FROM source2` is not identifier list, but the input query. The syntax here is for the header of INSERT and doesn't include the input query. A full query would look like `INSERT INTO t REPLACE WHERE ... (a, c) SELECT 1, 2`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org