panbingkun commented on code in PR #38520:
URL: https://github.com/apache/spark/pull/38520#discussion_r1014793728
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala:
##########
@@ -745,4 +745,52 @@ class ExpressionTypeCheckingSuite extends SparkFunSuite
with SQLHelper with Quer
)
)
}
+
+ test("check types for Lag") {
+ val lag = Lag(Literal(1), NonFoldableLiteral(10), Literal(null), true)
+ assert(lag.checkInputDataTypes() ==
Review Comment:
Actually, I have added another UT from the perspective of user-facing in the
'[DataFrameWindowFunctionsSuite.scala](https://github.com/apache/spark/pull/38520/files#diff-a7bdc96518ada8a7be55fe02d5fcc0080a4fff8e09819f87188d02edba9f4dc2)'
for 'FRAME_LESS_OFFSET_WITHOUT_FOLDABLE' error class.
<img width="532" alt="image"
src="https://user-images.githubusercontent.com/15246973/200162463-22e2c622-170e-4e41-8740-fb828e628411.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/15246973/200162463-22e2c622-170e-4e41-8740-fb828e628411.png"](https://user-images.githubusercontent.com/15246973/200162463-22e2c622-170e-4e41-8740-fb828e628411.png"){kind=link}