MaxGekk commented on code in PR #38520:
URL: https://github.com/apache/spark/pull/38520#discussion_r1015171962
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala:
##########
@@ -745,4 +745,52 @@ class ExpressionTypeCheckingSuite extends SparkFunSuite
with SQLHelper with Quer
)
)
}
+
+ test("check types for Lag") {
+ val lag = Lag(Literal(1), NonFoldableLiteral(10), Literal(null), true)
+ assert(lag.checkInputDataTypes() ==
+ DataTypeMismatch(
+ errorSubClass = "FRAME_LESS_OFFSET_WITHOUT_FOLDABLE",
+ messageParameters = Map("offset" -> "\"(- nonfoldableliteral())\"")
+ ))
+ }
+
+ test("check types for SpecifiedWindowFrame") {
+ val swf1 = SpecifiedWindowFrame(RangeFrame, Literal(10.0),
Literal(2147483648L))
+ assert(swf1.checkInputDataTypes() ==
+ DataTypeMismatch(
+ errorSubClass = "SPECIFIED_WINDOW_FRAME_DIFF_TYPES",
+ messageParameters = Map(
+ "lower" -> "\"10.0\"",
+ "upper" -> "\"2147483648\"",
+ "lowerType" -> "\"DOUBLE\"",
+ "upperType" -> "\"BIGINT\""
+ )
+ )
+ )
+
+ val swf2 = SpecifiedWindowFrame(RangeFrame, NonFoldableLiteral(10.0),
Literal(2147483648L))
+ assert(swf2.checkInputDataTypes() ==
+ DataTypeMismatch(
+ errorSubClass = "SPECIFIED_WINDOW_FRAME_WITHOUT_FOLDABLE",
+ messageParameters = Map(
+ "location" -> "lower",
+ "expression" -> "\"nonfoldableliteral()\""
+ )
+ )
+ )
+ }
+
+ test("check types for WindowSpecDefinition") {
+ val wsd = WindowSpecDefinition(
Review Comment:
@panbingkun Could you open a separate PR and convert it to an internal
error, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
