cloud-fan commented on code in PR #38358:
URL: https://github.com/apache/spark/pull/38358#discussion_r1016668422
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala:
##########
@@ -222,7 +222,7 @@ case class AdaptiveSparkPlanExec(
.map(_.toLong).filter(SQLExecution.getQueryExecution(_) eq context.qe)
}
- private def getFinalPhysicalPlan(): SparkPlan = lock.synchronized {
+ private[sql] def getFinalPhysicalPlan(): SparkPlan = lock.synchronized {
Review Comment:
looking at the code again, I think it's risky to call `getFinalPhysicalPlan`
directly. Other places call `withFinalPlanUpdate` which can handle UI update.
How about we add a new function here?
```
def finalPhysicalPlan = withFinalPlanUpdate(identity)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
