cloud-fan commented on code in PR #38358:
URL: https://github.com/apache/spark/pull/38358#discussion_r1016671794
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala:
##########
@@ -187,8 +188,17 @@ object FileFormatWriter extends Logging {
// We should first sort by partition columns, then bucket id, and finally
sorting columns.
val requiredOrdering =
partitionColumns ++ writerBucketSpec.map(_.bucketIdExpression) ++
sortColumns
+
+ // SPARK-40588: plan may contain an AdaptiveSparkPlanExec, which does not
know
+ // its final plan's ordering, so we have to materialize that plan first
Review Comment:
```suggestion
// SPARK-40588: AdaptiveSparkPlanExec does not know its output
partitioning and ordering before
// all its query stages are materialized. Here we have to materialize it
first, before adding SortExec.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
