cloud-fan commented on code in PR #38578:
URL: https://github.com/apache/spark/pull/38578#discussion_r1017875279
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -273,6 +274,21 @@ message StatFunction {
message Summary {
repeated string statistics = 1;
}
+
Review Comment:
shall we make the proto message a bit more flattened? It looks to me that
the only shared part between `Summary` and `CrossTabulate` is the input
relation. Shall we simply have 2 messages?
```
message StatsSummary {
Relation input = 1;
...
}
message StatsCrossTabulate {
Relation input = 1;
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
