amaliujia commented on code in PR #38578:
URL: https://github.com/apache/spark/pull/38578#discussion_r1018277889
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -273,6 +274,21 @@ message StatFunction {
message Summary {
repeated string statistics = 1;
}
+
Review Comment:
Or a different strategy is shared a field named arguments but the server
side will do more to differentiate the inputs for Summary, CrossTab, etc. This
seems to be bad.
Separating into different messages makes sense with existing example about
Summary and CrossTab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
