HyukjinKwon commented on code in PR #38535:
URL: https://github.com/apache/spark/pull/38535#discussion_r1018846038
##########
python/pyspark/sql/connect/client.py:
##########
@@ -125,13 +126,30 @@ def metadata(self) -> typing.Iterable[typing.Tuple[str,
str]]:
@property
def secure(self) -> bool:
+ if self._token is not None:
+ return True
+
value = self.params.get(ChannelBuilder.PARAM_USE_SSL, "")
return value.lower() == "true"
@property
def endpoint(self) -> str:
return f"{self.host}:{self.port}"
+ @property
+ def _token(self) -> Optional[str]:
+ return self.params.get(ChannelBuilder.PARAM_TOKEN, None)
+
+ @property
+ def user_id(self) -> Optional[str]:
Review Comment:
should probably follow camelCase .. Are these a lot to fix? Wonder if we
can fix them here together if there aren't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
