amaliujia commented on code in PR #38535:
URL: https://github.com/apache/spark/pull/38535#discussion_r1019656175
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -195,7 +195,15 @@ def test_invalid_connection_strings(self):
for i in invalid:
self.assertRaises(AttributeError, ChannelBuilder, i)
- self.assertRaises(AttributeError,
ChannelBuilder("sc://host/;token=123").to_channel)
+ def test_sensible_defaults(self):
+ chan = ChannelBuilder("sc://host")
Review Comment:
I might has missed your previous discussion:
why using, for example, `http` which is not a true http protocol in the
underlying implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
