amaliujia commented on code in PR #38621:
URL: https://github.com/apache/spark/pull/38621#discussion_r1020483723
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -253,6 +254,23 @@ message Repartition {
bool shuffle = 3;
}
+// Compose the string representing rows for output.
+// It will invoke 'Dataset.showString' to compute the results.
+message ShowString {
+ // (Required). The input relation.
+ Relation input = 1;
+
+ // (Required) Number of rows to show.
Review Comment:
I think we should have a proto message style guide ASAP that people agree.
For example required field with `optional` notion is very confusing.
IMO required field does not need `optional` to know set/unset. We say it is
required which means clients should always offer a value. Server side just use
the value ( only Messages are exceptions because if that is not set, it will
give a NULL, which is problematic for JVM languages which is NPE).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
