zhengruifeng commented on code in PR #38621:
URL: https://github.com/apache/spark/pull/38621#discussion_r1020992753
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -217,6 +217,12 @@ def test_empty_dataset(self):
def test_session(self):
self.assertEqual(self.connect, self.connect.sql("SELECT
1").sparkSession())
+ def test_show(self):
+ # SPARK-41111: Test the show method
+ show_str = self.connect.sql("SELECT 1 AS X, 2 AS Y")._show_string()
+ expected = "+---+---+\n| X| Y|\n+---+---+\n| 1| 2|\n+---+---+\n"
Review Comment:
I think we can make such change since it break the lint
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -217,6 +217,12 @@ def test_empty_dataset(self):
def test_session(self):
self.assertEqual(self.connect, self.connect.sql("SELECT
1").sparkSession())
+ def test_show(self):
+ # SPARK-41111: Test the show method
+ show_str = self.connect.sql("SELECT 1 AS X, 2 AS Y")._show_string()
+ expected = "+---+---+\n| X| Y|\n+---+---+\n| 1| 2|\n+---+---+\n"
Review Comment:
I think we cannot make such change since it break the lint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
