panbingkun commented on code in PR #38531:
URL: https://github.com/apache/spark/pull/38531#discussion_r1020752639
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -290,6 +290,46 @@
"Null typed values cannot be used as arguments of <functionName>."
]
},
+ "NUMBER_FORMAT_CURRENCY_MUST_BEFORE_DECIMAL" : {
+ "message" : [
+ "Currency characters must appear before any decimal point in the
number format: '<numberFormat>'"
Review Comment:
Here are all subclasses of DATATYPE_MISMATCH.
Do we really need Level 3 error classes? @MaxGekk
If we keep Level 2 error classes, INVALID_NUMBER_FORMAT....
The naming rule is inconsistent with other subclasses, eg:
RANGE_FRAME_INVALID_TYPE, RANGE_FRAME_MULTI_ORDER,
RANGE_FRAME_WITHOUT_ORDER...
If we merge two flavors for SEPARATOR and CURRENCY, We have to put these
characters into the message parameters, which seems inconvenient for subsequent
internationalization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
