MaxGekk commented on code in PR #38531:
URL: https://github.com/apache/spark/pull/38531#discussion_r1020757754
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -290,6 +290,46 @@
"Null typed values cannot be used as arguments of <functionName>."
]
},
+ "NUMBER_FORMAT_CURRENCY_MUST_BEFORE_DECIMAL" : {
+ "message" : [
+ "Currency characters must appear before any decimal point in the
number format: '<numberFormat>'"
Review Comment:
> Do we really need Level 3 error classes? @MaxGekk
I don't think it makes sense.
> If we keep Level 2 error classes, INVALID_NUMBER_FORMAT....
Let's make the prefix shorter, for instance `NUM_FORMAT` like
`DATATYPE_MISMATCH.NUM_FORMAT_CONT_THOUSANDS_SEPS`
instead of
`DATATYPE_MISMATCH.NUMBER_FORMAT_THOUSANDS_SEPARATOR_MUST_HAVE_DIGIT_IN_BETWEEN`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
