amaliujia commented on code in PR #38627:
URL: https://github.com/apache/spark/pull/38627#discussion_r1021065389
##########
connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala:
##########
@@ -148,29 +147,25 @@ class SparkConnectProtoSuite extends PlanTest with
SparkConnectPlanTest {
}
test("Aggregate with more than 1 grouping expressions") {
- withSQLConf(SQLConf.DATAFRAME_RETAIN_GROUP_COLUMNS.key -> "false") {
- val connectPlan =
- connectTestRelation.groupBy("id".protoAttr, "name".protoAttr)()
- val sparkPlan =
- sparkTestRelation.groupBy(Column("id"),
Column("name")).agg(Map.empty[String, String])
- comparePlans(connectPlan, sparkPlan)
- }
+ val connectPlan =
+ connectTestRelation.groupBy("id".protoAttr, "name".protoAttr)()
+ val sparkPlan =
+ sparkTestRelation.groupBy(Column("id"),
Column("name")).agg(Map.empty[String, String])
+ comparePlans(connectPlan, sparkPlan)
}
test("Aggregate expressions") {
- withSQLConf(SQLConf.DATAFRAME_RETAIN_GROUP_COLUMNS.key -> "false") {
Review Comment:
makes sense. Let me drive a consensus on this. The usage `__repr__` probably
can vote +1 on the client side configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
