grundprinzip commented on code in PR #38627:
URL: https://github.com/apache/spark/pull/38627#discussion_r1021117249
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -441,11 +441,14 @@ class SparkConnectPlanner(session: SparkSession) {
case x => UnresolvedAlias(x)
}
+ // Retain group columns in aggregate expressions:
+ val aggExprs =
+ groupingExprs ++
rel.getResultExpressionsList.asScala.map(transformResultExpression)
Review Comment:
@cloud-fan from your experience how often have you seen someone to
explicitly set the flag since the default was changed in Spark 2.x? I don't
think it's worth it adding the full concept of session options and using this
as the prime example.
Our goal should be to simplify, and the users can still override the
defaults on the server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
