cloud-fan commented on code in PR #38631:
URL: https://github.com/apache/spark/pull/38631#discussion_r1021211335
##########
connector/connect/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -170,6 +170,8 @@ message Expression {
message Alias {
Expression expr = 1;
- string name = 2;
+ repeated string name = 2;
+ // Alias metadata expressed as a JSON map.
+ optional string metadata = 3;
Review Comment:
nit: previously @amaliujia added
```
message DataSource {
// Required. Supported formats include: parquet, orc, text, json,
parquet, csv, avro.
string format = 1;
// Optional. If not set, Spark will infer the schema.
string schema = 2;
// The key is case insensitive.
map<string, string> options = 3;
}
```
Shall we also have a guideline for adding string-string map field? Do we
prefer proto map field or just JSON string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
