cloud-fan commented on code in PR #38631:
URL: https://github.com/apache/spark/pull/38631#discussion_r1021212753
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -348,7 +350,16 @@ class SparkConnectPlanner(session: SparkSession) {
}
private def transformAlias(alias: proto.Expression.Alias): NamedExpression =
{
- Alias(transformExpression(alias.getExpr), alias.getName)()
+ if (alias.getNameCount == 1) {
+ val md = if (alias.hasMetadata()) {
+ Some(Metadata.fromJson(alias.getMetadata))
+ } else {
+ None
+ }
+ Alias(transformExpression(alias.getExpr),
alias.getName(0))(explicitMetadata = md)
+ } else {
+ MultiAlias(transformExpression(alias.getExpr),
alias.getNameList.asScala.toSeq)
Review Comment:
shall we fail here if `alias.hasMetadata` is true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
