amaliujia commented on code in PR #38638:
URL: https://github.com/apache/spark/pull/38638#discussion_r1021980330
##########
connector/connect/src/main/protobuf/spark/connect/base.proto:
##########
@@ -48,6 +72,9 @@ message Request {
// The logical plan to be executed / analyzed.
Plan plan = 3;
+ // (Required) For analyzePlan rpc calls, configure the mode to explain plan
in strings.
+ ExplainMode explain_mode= 4;
Review Comment:
I make `Explain` as a message now. However given how we split the rpc call,
this message needs to stay in `base.proto`:
```
// Main interface for the SparkConnect service.
service SparkConnectService {
// Executes a request that contains the query and returns a stream of
[[Response]].
rpc ExecutePlan(Request) returns (stream Response) {}
// Analyzes a query and returns a [[AnalyzeResponse]] containing metadata
about the query.
rpc AnalyzePlan(Request) returns (AnalyzeResponse) {}
}
```
There might be better way to organize it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
