HyukjinKwon commented on code in PR #38638:
URL: https://github.com/apache/spark/pull/38638#discussion_r1022286561


##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -667,12 +668,70 @@ def schema(self) -> StructType:
         else:
             return self._schema
 
-    def explain(self) -> str:
+    def explain(
+        self, extended: Optional[Union[bool, str]] = None, mode: Optional[str] 
= None

Review Comment:
   We could leverage keyword-only argument to simplify this for now. cc 
@zhengruifeng and @ueshin 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to