MaxGekk commented on code in PR #38531:
URL: https://github.com/apache/spark/pull/38531#discussion_r1022613029


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -290,6 +290,46 @@
           "Null typed values cannot be used as arguments of <functionName>."
         ]
       },
+      "NUM_FORMAT_CONT_THOUSANDS_SEPS" : {

Review Comment:
   > Some are query compile time static checks
   
   I would like to propose to do refactoring later. Let's assign unique error 
classes to the errors that come from `checkInputDataTypes()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to