srielau commented on code in PR #38531:
URL: https://github.com/apache/spark/pull/38531#discussion_r1022941891


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -290,6 +290,46 @@
           "Null typed values cannot be used as arguments of <functionName>."
         ]
       },
+      "NUM_FORMAT_CONT_THOUSANDS_SEPS" : {

Review Comment:
   This must be fixed before we cut 12.0.
   Also there is no joy in having an error class with dozens of subclasses 
because it makes for a deeper doc tree.
   
   By this logic a CONSTRAINT violation is a data type mismatch and so is a NOT 
NULL violation....
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to