pan3793 commented on code in PR #38651: URL: https://github.com/apache/spark/pull/38651#discussion_r1023478697
########## resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshotsStoreImpl.scala: ########## @@ -57,6 +60,7 @@ import org.apache.spark.util.ThreadUtils * The subscriber notification callback is guaranteed to be called from a single thread at a time. */ private[spark] class ExecutorPodsSnapshotsStoreImpl( + conf: SparkConf, Review Comment: the backward-compatible constructors were added ########## resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala: ########## @@ -723,6 +723,18 @@ private[spark] object Config extends Logging { .checkValue(value => value > 0, "Maximum number of pending pods should be a positive integer") .createWithDefault(Int.MaxValue) + val KUBERNETES_EXECUTOR_SNAPSHOTS_SUBSCRIBERS_GRACE_PERIOD = + ConfigBuilder("spark.kubernetes.executorSnapshotsSubscribersShutdownGracePeriod") + .doc("Time to wait for graceful shutdown kubernetes-executor-snapshots-subscribers " + + "thread pool. Since it may be called by ShutdownHookManager, where timeout is " + + "controlled by hadoop configuration `hadoop.service.shutdown.timeout` " + + "(default is 30s). As the whole Spark shutdown procedure shares the above timeout, " + + "this value should be short than that to prevent blocking the following shutdown " + + "procedures.") + .version("3.4.0") + .timeConf(TimeUnit.SECONDS) Review Comment: added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org