viirya commented on code in PR #38692:
URL: https://github.com/apache/spark/pull/38692#discussion_r1026176496
##########
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala:
##########
@@ -192,6 +192,23 @@ class SparkSessionExtensionSuite extends SparkFunSuite
with SQLHelper {
testInjectColumnar(false)
}
+ test("inject plan normalization rules") {
+ val extensions = create { extensions =>
+ extensions.injectPlanNormalizationRules { session =>
+ org.apache.spark.sql.catalyst.optimizer.PushDownPredicates
+ }
+ }
+ withSession(extensions) { session =>
+ import session.implicits._
+ val df = Seq((1, "a"), (2, "b")).toDF("i", "s")
+ df.select("i").filter($"i" > 1).cache()
+ assert(df.filter($"i" > 1).select("i").queryExecution.executedPlan.find {
+ case _: org.apache.spark.sql.execution.columnar.InMemoryTableScanExec
=> true
+ case _ => false
Review Comment:
So without the added rule, caching is unable to apply here, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
