cloud-fan commented on code in PR #38692:
URL: https://github.com/apache/spark/pull/38692#discussion_r1026569958
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala:
##########
@@ -217,6 +218,22 @@ class SparkSessionExtensions {
checkRuleBuilders += builder
}
+ private[this] val planNormalizationRules = mutable.Buffer.empty[RuleBuilder]
+
+ def buildPlanNormalizationRules(session: SparkSession):
Seq[Rule[LogicalPlan]] = {
+ planNormalizationRules.map(_.apply(session)).toSeq
Review Comment:
I'm following the existing code style in this file. I assume the reason is
people who are not familiar with Scala may be confused when reading the code
`.map(_(session))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]