gengliangwang commented on code in PR #38567:
URL: https://github.com/apache/spark/pull/38567#discussion_r1027640551
##########
core/src/main/scala/org/apache/spark/status/AppStatusStore.scala:
##########
@@ -769,7 +772,14 @@ private[spark] object AppStatusStore {
def createLiveStore(
conf: SparkConf,
appStatusSource: Option[AppStatusSource] = None): AppStatusStore = {
- val store = new ElementTrackingStore(new InMemoryStore(), conf)
+ val storePath = conf.get(LIVE_UI_LOCAL_STORE_DIR).map(new File(_))
+ // For the disk-based KV store of live UI, let's simply make it ROCKSDB
only for now,
+ // instead of supporting both LevelDB and RocksDB. RocksDB is built based
on LevelDB with
+ // improvements on writes and reads. Furthermore, we can reuse the
RocksDBFileManager in
+ // streaming for replicating the local RocksDB file to DFS. The
replication in DFS can be
+ // used for Spark history server.
Review Comment:
Thanks, I have removed the comment about replication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
