cloud-fan commented on code in PR #38779:
URL: https://github.com/apache/spark/pull/38779#discussion_r1032083177
##########
project/SparkBuild.scala:
##########
@@ -611,9 +611,23 @@ object SparkParallelTestGrouping {
object Core {
import scala.sys.process.Process
+ import BuildCommons.protoVersion
def buildenv = Process(Seq("uname")).!!.trim.replaceFirst("[^A-Za-z0-9].*",
"").toLowerCase
def bashpath = Process(Seq("where",
"bash")).!!.split("[\r\n]+").head.replace('\\', '/')
lazy val settings = Seq(
+ // Setting version for the protobuf compiler. This has to be propagated to
every sub-project
+ // even if the project is not using it.
+ PB.protocVersion := BuildCommons.protoVersion,
Review Comment:
did we copy these code from somewhere?
##########
core/src/main/scala/org/apache/spark/status/protobuf/JobDataWrapperSerializer.scala:
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.status.protobuf
+
+import collection.JavaConverters._
+import java.util.Date
+
+import org.apache.spark.JobExecutionStatus
+import org.apache.spark.status.JobDataWrapper
+import org.apache.spark.status.api.v1.JobData
+
+object JobDataWrapperSerializer {
+ def serialize(j: JobDataWrapper): Array[Byte] = {
+ val jobData = serializeJobData(j.info)
+ val builder = StoreTypes.JobDataWrapper.newBuilder()
+ builder.setInfo(jobData)
+ j.skippedStages.foreach(builder.addSkippedStages)
+ j.sqlExecutionId.foreach(builder.setSqlExecutionId)
+ builder.build().toByteArray
+ }
+
+ def deserialize(bytes: Array[Byte]): JobDataWrapper = {
+ val wrapper = StoreTypes.JobDataWrapper.parseFrom(bytes)
+ val sqlExecutionId = getOptional(wrapper.hasSqlExecutionId,
wrapper.getSqlExecutionId)
+ new JobDataWrapper(
+ deserializeJobData(wrapper.getInfo),
+ wrapper.getSkippedStagesList.asScala.map(_.toInt).toSet,
+ sqlExecutionId
+ )
+ }
+
+ private def getOptional[T](condition: Boolean, result: () => T): Option[T] =
if (condition) {
+ Some(result())
+ } else {
+ None
+ }
+
+ private def serializeJobData(jobData: JobData): StoreTypes.JobData = {
+ val jobDataBuilder = StoreTypes.JobData.newBuilder()
+ jobDataBuilder.setJobId(jobData.jobId)
+ .setName(jobData.name)
+ .setStatus(serializeJobExecutionStatus(jobData.status))
+ .setNumTasks(jobData.numTasks)
+ .setNumActiveTasks(jobData.numActiveTasks)
+ .setNumCompletedTasks(jobData.numCompletedTasks)
+ .setNumSkippedTasks(jobData.numSkippedTasks)
+ .setNumFailedTasks(jobData.numFailedTasks)
+ .setNumKilledTasks(jobData.numKilledTasks)
+ .setNumCompletedIndices(jobData.numCompletedIndices)
+ .setNumActiveStages(jobData.numActiveStages)
+ .setNumCompletedStages(jobData.numCompletedStages)
+ .setNumSkippedStages(jobData.numSkippedStages)
+ .setNumFailedStages(jobData.numFailedStages)
+
+ jobData.description.foreach(jobDataBuilder.setDescription)
+ jobData.submissionTime.foreach { d =>
+ jobDataBuilder.setSubmissionTime(serializeDate(d))
+ }
+ jobData.completionTime.foreach { d =>
+ jobDataBuilder.setCompletionTime(serializeDate(d))
+ }
+ jobData.stageIds.foreach(jobDataBuilder.addStageIds)
+ jobData.jobGroup.foreach(jobDataBuilder.setJobGroup)
+ jobData.killedTasksSummary.foreach { entry =>
+ jobDataBuilder.putKillTasksSummary(entry._1, entry._2)
+ }
+ jobDataBuilder.build()
+ }
+
+ private def deserializeJobData(info: StoreTypes.JobData): JobData = {
+ val description = if (info.hasDescription) {
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
